Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest: WiresharkFoundation.Wireshark version 4.4.0 #172687

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Update manifest: WiresharkFoundation.Wireshark version 4.4.0 #172687

merged 2 commits into from
Sep 11, 2024

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Sep 10, 2024 •
edited by microsoft-github-policy-service bot
Loading

Details

  • Add arm64 EXE of the package

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Dragon1573
Update manifest: WiresharkFoundation.Wireshark version 4.4.0
87c1bc8 
- Add `arm64 EXE` of the package

Signed-off-by: Dragon1573 <[email protected]>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 10, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Sep 10, 2024 •
edited
Loading

Hi @Dragon1573,

This manifest adds a DisplayVersion to the AppsAndFeaturesEntries that isn't present in previous manifest versions. This entry should be added to the previous versions, or removed from this version.

(Automated response - build 895.)

Edit: The DisplayVersion should be used carefully, as it can easily cause several issues. Here, it seems to only add a trailing .0 to the PackageVersion, which the package manager does by default.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 11, 2024
@Dragon1573
Remove DisplayVersion in the manifest
0569af3 
- Use this property with caution.
auto-merge was automatically disabled September 11, 2024 06:09

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed labels Sep 11, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit c96296d into microsoft:master Sep 11, 2024
8 checks passed
@Dragon1573 Dragon1573 deleted the issues/172612 branch September 11, 2024 15:11
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@dingwen07
Copy link
Contributor

Hi,

I have done winget source update however WinGet somehow is still trying to install x64 version.

winget install WiresharkFoundation.Wireshark
Found Wireshark [WiresharkFoundation.Wireshark] Version 4.4.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://2.na.dl.wireshark.org/win64/Wireshark-4.4.0-x64.msi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: WiresharkFoundation.Wireshark Arm64 architecture
5 participants
@Dragon1573 @wingetbot @stephengillie @dingwen07 @ItzLevvie